Revert "[media] drivers/media/usb/dvb-usb/dib0700_core.c: fix left shift"
authorMauro Carvalho Chehab <mchehab@redhat.com>
Wed, 6 Feb 2013 10:29:39 +0000 (08:29 -0200)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Wed, 6 Feb 2013 10:31:55 +0000 (08:31 -0200)
commitf85ed0ceeba78b6b15a857ce48888fdb52de28d0
tree6cf49bd4d9f0cf1786bc0e5a16cd002efd009d5c
parent6a05d66b8ff1e3a3470186d25cd825dff774bb82
Revert "[media] drivers/media/usb/dvb-usb/dib0700_core.c: fix left shift"

On Wed, 6 Feb 2013 09:04:39 +0000
Olivier GRENIE <olivier.grenie@parrot.com> wrote:

> I do not agree with the patch. Let's take an example: adap->id = 0. Then:
>  * 1 << ~(adap->id) = 1 << ~(0) = 0
>  * ~(1 << adap->id) = ~(1 << 0) = 0xFE
>
> The correct change should be: st->channel_state |= 1 << (1 - adap->id); Indeed, the original source code was not correct.

Requested-by: Olivier GRENIE <olivier.grenie@parrot.com>
Cc: Patrick Boettcher <patrick.boettcher@dibcom.fr>
Cc: Nickolai Zeldovich <nickolai@csail.mit.edu>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/usb/dvb-usb/dib0700_core.c