projects / sdk / emulator / qemu.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 5d32173) | patch
xhci: Fix possible side effect from assert()
authorAlexey Kardashevskiy <aik@ozlabs.ru>
Mon, 18 Jul 2016 03:29:08 +0000 (13:29 +1000)
committerGerd Hoffmann <kraxel@redhat.com>
Wed, 20 Jul 2016 11:31:09 +0000 (13:31 +0200)
commitf81bb347ef80e94204b719e1d5e827babb556220
tree3494801562c5adc2faf9f3f6c575c00694b31317tree | snapshot
parent5d3217340adcb6c4f0e4af5d2b865331eb2ff63dcommit | diff
xhci: Fix possible side effect from assert()

A static analysis tool called BEAM detected possible side effect from
assert() calling a helper which may change an XHCI ring after every call.

This moves xhci_ring_fetch() out of assert() so it will be called
with and without enabled debug.

Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Message-id: 1468812548-31868-1-git-send-email-aik@ozlabs.ru
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
hw/usb/hcd-xhci.c diff | blob | history
Domain: SDK / Emulator;