watchdog: s3c2410: Fix getting the optional clock
authorSam Protsenko <semen.protsenko@linaro.org>
Sun, 12 Dec 2021 17:02:47 +0000 (19:02 +0200)
committerWim Van Sebroeck <wim@linux-watchdog.org>
Wed, 5 Jan 2022 09:38:37 +0000 (10:38 +0100)
commitf7bcb02390ad319ecc4161b9c9989f710fa6edb2
treedd82b9ec7d10efb66748a46d098737787add53ef
parenta51f589693899a0325a4381098bbb96e06204983
watchdog: s3c2410: Fix getting the optional clock

"watchdog_src" clock is optional and may not be present for some SoCs
supported by this driver. Nevertheless, in case the clock is provided
but some error happens during its getting, that error should be handled
properly. Use devm_clk_get_optional() API for that. Also report possible
errors using dev_err_probe() to handle properly -EPROBE_DEFER error (if
clock provider is not ready by the time WDT probe function is executed).

Fixes: e249d01b5e8b ("watchdog: s3c2410: Support separate source clock")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Suggested-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Link: https://lore.kernel.org/r/20211212170247.30646-1-semen.protsenko@linaro.org
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
drivers/watchdog/s3c2410_wdt.c