[mlir] Remove AppendToArgumentsList functionality from BufferizeTypeConverter.
authorSean Silva <silvasean@google.com>
Wed, 4 Nov 2020 18:57:29 +0000 (10:57 -0800)
committerSean Silva <silvasean@google.com>
Thu, 5 Nov 2020 19:20:09 +0000 (11:20 -0800)
commitf7bc56826616814a656866fd50e90a35a8e461eb
tree6474a0b8df2496264e8ec8280a354670d9243ed4
parentf347d78cca9a6b218e98d562b0e066488279602e
[mlir] Remove AppendToArgumentsList functionality from BufferizeTypeConverter.

This functionality is superceded by BufferResultsToOutParams pass (see
https://reviews.llvm.org/D90071) for users the require buffers to be
out-params. That pass should be run immediately after all tensors are gone from
the program (before buffer optimizations and deallocation insertion), such as
immediately after a "finalizing" bufferize pass.

The -test-finalizing-bufferize pass now defaults to what used to be the
`allowMemrefFunctionResults=true` flag. and the
finalizing-bufferize-allowed-memref-results.mlir file is moved
to test/Transforms/finalizing-bufferize.mlir.

Differential Revision: https://reviews.llvm.org/D90778
mlir/include/mlir/Transforms/Bufferize.h
mlir/lib/Transforms/Bufferize.cpp
mlir/test/Transforms/finalizing-bufferize-allowed-memref-results.mlir [deleted file]
mlir/test/Transforms/finalizing-bufferize.mlir
mlir/test/lib/Transforms/TestFinalizingBufferize.cpp
mlir/tools/mlir-opt/mlir-opt.cpp