nfsd: Remove incorrect check in nfsd4_validate_stateid
authorTrond Myklebust <trond.myklebust@hammerspace.com>
Tue, 18 Jul 2023 12:38:37 +0000 (08:38 -0400)
committerChuck Lever <chuck.lever@oracle.com>
Tue, 18 Jul 2023 15:34:09 +0000 (11:34 -0400)
commitf75546f58a70da5cfdcec5a45ffc377885ccbee8
treea07a7c7caba1dd45eeae858649fdb8ff37074074
parentd7dbed457c2ef83709a2a2723a2d58de43623449
nfsd: Remove incorrect check in nfsd4_validate_stateid

If the client is calling TEST_STATEID, then it is because some event
occurred that requires it to check all the stateids for validity and
call FREE_STATEID on the ones that have been revoked. In this case,
either the stateid exists in the list of stateids associated with that
nfs4_client, in which case it should be tested, or it does not. There
are no additional conditions to be considered.

Reported-by: "Frank Ch. Eigler" <fche@redhat.com>
Fixes: 7df302f75ee2 ("NFSD: TEST_STATEID should not return NFS4ERR_STALE_STATEID")
Cc: stable@vger.kernel.org # v5.7+
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
fs/nfsd/nfs4state.c