mmc: fix mmc mode selection for HS-DDR and higher
authorChen-Yu Tsai <wens@csie.org>
Sun, 29 May 2016 07:04:42 +0000 (15:04 +0800)
committerUlf Hansson <ulf.hansson@linaro.org>
Thu, 2 Jun 2016 08:39:05 +0000 (10:39 +0200)
commitf741494363c6c90e6744117d2771bbdf0fb3c455
tree631a6a08eebc95f150c797a44ea4714c7c6ea57e
parent1a695a905c18548062509178b98bc91e67510864
mmc: fix mmc mode selection for HS-DDR and higher

When IS_ERR_VALUE was removed from the mmc core code, it was replaced
with a simple not-zero check. This does not work, as the value checked
is the return value for mmc_select_bus_width, which returns the set
bit width on success. This made eMMC modes higher than HS-DDR unusable.

Fix this by checking for a positive return value instead.

Fixes: 287980e49ffc ("remove lots of IS_ERR_VALUE abuses")
Cc: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Acked-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Acked-by: Jaehoon Chung <jh80.chung@samsung.com>
Reviewed-by: Shawn Lin <shawn.lin@rock-chips.com>
Tested-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
Tested-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/core/mmc.c