Encode calling convention in mangled function pointer representation (#81122)
authorTomáš Rylek <trylek@microsoft.com>
Tue, 31 Jan 2023 20:52:14 +0000 (21:52 +0100)
committerGitHub <noreply@github.com>
Tue, 31 Jan 2023 20:52:14 +0000 (21:52 +0100)
commitf70d8a9663d3d674c453e26d405dc13baa79fd16
tree5f579b099aa691283029ba9ab1eba9e3d7d4f256
parent0043b6ea3328ea1b3ae00a57f7ccd497857f7282
Encode calling convention in mangled function pointer representation (#81122)

This fixes the recently introduced issue #81106 tracking Crossgen2
crash due to not being able to distinguish two function pointers
differing only by calling convention (one of the pointers is Static
and the other is Static | UnmanagedCallingConvention).

This change also removes the issues.targets exclusion for the
new function pointer test that Fan Yang had to add to unblock
merging in the test in the first place.

Thanks

Tomas

* Delete superfluous comment per Michal's PR feedback
src/coreclr/tools/Common/Compiler/NativeAotNameMangler.cs
src/tests/issues.targets