bio-integrity: Fix bio_integrity_verify segment start bug
authorNicholas Bellinger <nab@linux-iscsi.org>
Sun, 2 Mar 2014 01:00:16 +0000 (17:00 -0800)
committerJiri Slaby <jslaby@suse.cz>
Wed, 5 Mar 2014 09:54:28 +0000 (10:54 +0100)
commitf6f27128f7b3bea1236abd88d56227e871e7dc2d
treedc64ba7789da909f4208516bc51b0418dcdf627c
parentb7b7b4554f1e0c38db6573cdd784f99aad886f37
bio-integrity: Fix bio_integrity_verify segment start bug

commit 5837c80e870bc3b12ac6a98cdc9ce7a9522a8fb6 upstream.

This patch addresses a bug in bio_integrity_verify() code that has
been causing DIF READ verify operations to be silently skipped.

The issue is that bio->bi_idx will have been incremented within
bio_advance() code in the normal blk_update_request() ->
req_bio_endio() completion path, and bio_integrity_verify() is
using bio_for_each_segment() which starts the bio segment walk
at the current bio->bi_idx.

So instead use bio_for_each_segment_all() to always start the bio
segment walk from zero, regardless of the current bio->bi_idx
value after bio_advance() has been called.

(Context change for v3.10.y -> v3.13.y code - nab)

Cc: Martin K. Petersen <martin.petersen@oracle.com>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Cc: stable@kernel.dk # >= v3.10
Signed-off-by: Jens Axboe <axboe@kernel.dk>
fs/bio-integrity.c