create_breapoint / explicit mode: Error out if there's garbage after the breakpoint...
authorPedro Alves <palves@redhat.com>
Mon, 8 Apr 2013 14:09:30 +0000 (14:09 +0000)
committerPedro Alves <palves@redhat.com>
Mon, 8 Apr 2013 14:09:30 +0000 (14:09 +0000)
commitf6de8ec2620da62f46cb4e3887b981677cdd9cdb
treeb9a0d682130d2443d1a850a87384ee8f005b17f8
parentf65ce5fb99ce664302abe4af1263fdbb0518d069
create_breapoint / explicit mode: Error out if there's garbage after the breakpoint location.

If !PARSE_CONDITION_AND_THREAD, then ARG is just the location, nothing
else.  The fact that the describing comment of create_breakpoint
doesn't mention this just looks like an oversight of when extra_string
was added.  "parse_condition_and_thread" has been a misnomer ever
since extra_string was added -- better rename it avoid more confusion.
This makes it "parse_arg", as that'll remain stable even if/when more
explicit parameters are added.

gdb/
2013-04-08  Pedro Alves  <palves@redhat.com>
    Keith Seitz  <keiths@redhat.com>

* breakpoint.c (create_breakpoint): Rename
"parse_condition_and_thread" parameter to "parse_arg".  Update
describing comment.  If !PARSE_ARG, then error out if ARG is not
the empty string after extracting the location.
* breakpoint.h (create_breakpoint): Rename
"parse_condition_and_thread" parameter to "parse_arg".

gdb/testsuite/
2013-04-08  Pedro Alves  <palves@redhat.com>

* gdb.mi/mi-break.exp (test_error): Add tests with garbage after
the location.
gdb/ChangeLog
gdb/breakpoint.c
gdb/breakpoint.h
gdb/testsuite/ChangeLog
gdb/testsuite/gdb.mi/mi-break.exp