ipmi:ssif: compare block number correctly for multi-part return messages
authorKamlakant Patel <kamlakantp@marvell.com>
Wed, 24 Apr 2019 11:50:43 +0000 (11:50 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 22 May 2019 05:37:43 +0000 (07:37 +0200)
commitf6de0a3b1e66d544c1e4b28b5e864c574baa6dcc
tree0eef24f178701263a404bb5b1c6d87d9364bc1fe
parent88681649ed8c88cfe565a55b47728edee91d6d53
ipmi:ssif: compare block number correctly for multi-part return messages

commit 55be8658c7e2feb11a5b5b33ee031791dbd23a69 upstream.

According to ipmi spec, block number is a number that is incremented,
starting with 0, for each new block of message data returned using the
middle transaction.

Here, the 'blocknum' is data[0] which always starts from zero(0) and
'ssif_info->multi_pos' starts from 1.
So, we need to add +1 to blocknum while comparing with multi_pos.

Fixes: 7d6380cd40f79 ("ipmi:ssif: Fix handling of multi-part return messages").
Reported-by: Kiran Kolukuluru <kirank@ami.com>
Signed-off-by: Kamlakant Patel <kamlakantp@marvell.com>
Message-Id: <1556106615-18722-1-git-send-email-kamlakantp@marvell.com>
[Also added a debug log if the block numbers don't match.]
Signed-off-by: Corey Minyard <cminyard@mvista.com>
Cc: stable@vger.kernel.org # 4.4
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/char/ipmi/ipmi_ssif.c