Handle gcc 7 warnings
authorCaio Marcelo de Oliveira Filho <caio.oliveira@intel.com>
Thu, 22 Feb 2018 01:54:57 +0000 (17:54 -0800)
committerAlexander Galazin <alexander.galazin@arm.com>
Mon, 13 Apr 2020 19:21:05 +0000 (21:21 +0200)
commitf69ec755a25fb66a74da9a357be518f71d820c6c
tree01e80a9e24ec1767f215b9fa4010ef6343256049
parentc367c00d94fc25ddfafebe40d8ca6687e6b17459
Handle gcc 7 warnings

- "-Wimplicit-fallthrough" warns on case conditions that
  fallthrough. GCC does have a way to accept conditions that have a
  comment about falling through inside the cases, but the codebase has
  other cases where a single comment explains the fallthrough for the
  whole switch. This warning is being ignored. It was not possible to
  use "-Wno-error=WARNING" because older GCCs fail -- but they do
  accept "-Wno-WARNING" where WARNING is unknown (since at least gcc
  4.6.4).

- "-Wint-in-bool-context" warns (among other things) about result of
  multiplication being used in boolean context. Code was changed to
  use de::max() instead.

- "-Wmaybe-uninitialized" warned about some attributes of a struct not
  being initialized depending on the case. Code was changed to
  initialize the struct in question.

Components: Framework, Vulkan

Change-Id: Iabb26f01e047353c6e2a704ab27b673e85b185be
(cherry picked from commit f1ee9253e64f7434cdba7c8ac048c0e9baccc133)
external/vulkancts/modules/vulkan/shaderexecutor/vktShaderExecutor.cpp
external/vulkancts/modules/vulkan/texture/vktTextureFilteringExplicitLodTests.cpp
scripts/check_build_sanity.py