NFS: Guard against READDIR loop when entry names exceed MAXNAMELEN
authorBenjamin Coddington <bcodding@redhat.com>
Tue, 22 Aug 2023 18:22:38 +0000 (14:22 -0400)
committerAnna Schumaker <Anna.Schumaker@Netapp.com>
Wed, 30 Aug 2023 15:08:27 +0000 (11:08 -0400)
commitf67b55b6588bcf9316a1e6e8d529100a5aa3ebe6
treec790d554977c94f9a4eda281a195dd9174872c1f
parent51d674a5e4889f1c8e223ac131cf218e1631e423
NFS: Guard against READDIR loop when entry names exceed MAXNAMELEN

Commit 64cfca85bacd asserts the only valid return values for
nfs2/3_decode_dirent should not include -ENAMETOOLONG, but for a server
that sends a filename3 which exceeds MAXNAMELEN in a READDIR response the
client's behavior will be to endlessly retry the operation.

We could map -ENAMETOOLONG into -EBADCOOKIE, but that would produce
truncated listings without any error.  The client should return an error
for this case to clearly assert that the server implementation must be
corrected.

Fixes: 64cfca85bacd ("NFS: Return valid errors from nfs2/3_decode_dirent()")
Signed-off-by: Benjamin Coddington <bcodding@redhat.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
fs/nfs/nfs2xdr.c
fs/nfs/nfs3xdr.c