drm/dp_mst: Remove all evil duplicate state pointers
authorLyude Paul <lyude@redhat.com>
Tue, 23 Oct 2018 23:12:47 +0000 (19:12 -0400)
committerLyude Paul <lyude@redhat.com>
Wed, 24 Oct 2018 19:44:45 +0000 (15:44 -0400)
commitf6764815358b57c520ea137599e8297479bded4c
tree98e3602e78738c96ea182a1061196b571d091941
parente4b0c868106d7ef6a4a456a693e25e3b94942e54
drm/dp_mst: Remove all evil duplicate state pointers

There's no reason to track the atomic state three times. Unfortunately,
this is currently what we're doing, and even worse is that there is only
one actually correct state pointer: the one in mst_state->base.state.
mgr->state never seems to be used, along with the one in
mst_state->state.

This confused me for over 4 hours until I realized there was no magic
behind these pointers. So, let's save everyone else from the trouble.

Signed-off-by: Lyude Paul <lyude@redhat.com>.
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20181023231251.16883-3-lyude@redhat.com
include/drm/drm_dp_mst_helper.h