memory: atmel-ebi: Use struct_size() in devm_kzalloc()
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Fri, 24 Aug 2018 01:07:06 +0000 (20:07 -0500)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Mon, 27 Aug 2018 21:10:31 +0000 (23:10 +0200)
commitf62df676d7f16580fa5085a8f51a1cbe27f7dd10
treebb4461e296a1c7b3e26bd1460825794712247b43
parent5b394b2ddf0347bef56e50c69a58773c94343ff3
memory: atmel-ebi: Use struct_size() in devm_kzalloc()

One of the more common cases of allocation size calculations is finding
the size of a structure that has a zero-sized array at the end, along
with memory for some number of elements for that array. For example:

struct foo {
int stuff;
        void *entry[];
};

instance = devm_kzalloc(dev, sizeof(struct foo) + sizeof(void *) * count, GFP_KERNEL);

Instead of leaving these open-coded and prone to type mistakes, we can
now use the new struct_size() helper:

instance = devm_kzalloc(dev, struct_size(instance, entry, count), GFP_KERNEL);

This issue was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/memory/atmel-ebi.c