ext4: fix ext4_dax_read/write inode locking sequence for IOCB_NOWAIT
authorRitesh Harjani <riteshh@linux.ibm.com>
Thu, 12 Dec 2019 05:55:55 +0000 (11:25 +0530)
committerTheodore Ts'o <tytso@mit.edu>
Mon, 23 Dec 2019 04:57:27 +0000 (23:57 -0500)
commitf629afe3369e9885fd6e9cc7a4f514b6a65cf9e9
tree7f7b3f170985b97099e2c7b9f149ebc0975e41eb
parent46cf053efec6a3a5f343fead837777efe8252a46
ext4: fix ext4_dax_read/write inode locking sequence for IOCB_NOWAIT

Apparently our current rwsem code doesn't like doing the trylock, then
lock for real scheme.  So change our dax read/write methods to just do the
trylock for the RWF_NOWAIT case.
This seems to fix AIM7 regression in some scalable filesystems upto ~25%
in some cases. Claimed in commit 942491c9e6d6 ("xfs: fix AIM7 regression")

Reviewed-by: Jan Kara <jack@suse.cz>
Reviewed-by: Matthew Bobrowski <mbobrowski@mbobrowski.org>
Tested-by: Joseph Qi <joseph.qi@linux.alibaba.com>
Signed-off-by: Ritesh Harjani <riteshh@linux.ibm.com>
Link: https://lore.kernel.org/r/20191212055557.11151-2-riteshh@linux.ibm.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/ext4/file.c