sfc: Use kmap_local_page() instead of kmap_atomic()
authorAnirudh Venkataramanan <anirudh.venkataramanan@intel.com>
Wed, 23 Nov 2022 20:52:15 +0000 (12:52 -0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 25 Nov 2022 10:44:01 +0000 (10:44 +0000)
commitf61e6d3ca4dac83d7093e7be7ceabce95e738e68
tree4f78bb9fb791d6fb4337816d64be8e8cf374ffc5
parent51337ef07a40652efec48bb4103880c39ad0f119
sfc: Use kmap_local_page() instead of kmap_atomic()

kmap_atomic() is being deprecated in favor of kmap_local_page(). Replace
kmap_atomic() and kunmap_atomic() with kmap_local_page() and kunmap_local()
respectively.

Note that kmap_atomic() disables preemption and page-fault processing, but
kmap_local_page() doesn't. When converting uses of kmap_atomic(), one has
to check if the code being executed between the map/unmap implicitly
depends on page-faults and/or preemption being disabled. If yes, then code
to disable page-faults and/or preemption should also be added for
functional correctness. That however doesn't appear to be the case here,
so just kmap_local_page() is used.

Also note that the page being mapped is not allocated by the driver, and so
the driver doesn't know if the page is in normal memory. This is the reason
kmap_local_page() is used as opposed to page_address().

I don't have hardware, so this change has only been compile tested.

Cc: Ira Weiny <ira.weiny@intel.com>
Cc: Fabio M. De Francesco <fmdefrancesco@gmail.com>
Cc: Edward Cree <ecree.xilinx@gmail.com>
Cc: Martin Habets <habetsm.xilinx@gmail.com>
Signed-off-by: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>
Acked-by: Martin Habets <habetsm.xilinx@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/sfc/tx.c