projects / platform / kernel / linux-rpi.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 3de5eab) | patch
xfs: fix broken bhold behavior in xrep_roll_ag_trans
authorDarrick J. Wong <darrick.wong@oracle.com>
Wed, 24 Apr 2019 17:39:49 +0000 (10:39 -0700)
committerDarrick J. Wong <darrick.wong@oracle.com>
Fri, 26 Apr 2019 19:28:55 +0000 (12:28 -0700)
commitf60be90fc9a969d8d38d761aef1c930407a6a921
treed773b5fd7c8521cf39cba44bbb4f1baab7753361tree | snapshot
parent3de5eab3fde1e379be65973a69ded29da3802133commit | diff
xfs: fix broken bhold behavior in xrep_roll_ag_trans

In xrep_roll_ag_trans, the transaction roll will always set sc->tp to
the new transaction, even if committing the old one fails.  A bare
transaction roll leaves the buffer(s) locked but not joined to the new
transaction, so it's not necessary to release the hold if the roll
fails.  Remove the incorrect xfs_trans_bhold_release calls.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
fs/xfs/scrub/repair.c diff | blob | history
Domain: System / Kernel;