fs: dlm: Fix memory leak of object mh
authorColin Ian King <colin.king@canonical.com>
Wed, 26 May 2021 14:46:05 +0000 (15:46 +0100)
committerDavid Teigland <teigland@redhat.com>
Wed, 26 May 2021 14:49:04 +0000 (09:49 -0500)
commitf6089981d07e6e1cc053f4c239e458eed122c092
treee123eafa0c8593727070a7c81a79528d67744090
parent706474fbc5fedd7799b488962aad3541b235165b
fs: dlm: Fix memory leak of object mh

There is an error return path that is not kfree'ing mh after
it has been successfully allocates.  Fix this by moving the
call to create_rcom to after the check on rc_in->rc_id check
to avoid this.

Thanks to Alexander Ahring Oder Aring for suggesting the
correct way to fix this.

Addresses-Coverity: ("Resource leak")
Fixes: a070a91cf140 ("fs: dlm: add more midcomms hooks")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David Teigland <teigland@redhat.com>
fs/dlm/rcom.c