ksmbd: fix racy issue from session setup and logoff
authorNamjae Jeon <linkinjeon@kernel.org>
Wed, 3 May 2023 07:45:00 +0000 (16:45 +0900)
committerSteve French <stfrench@microsoft.com>
Thu, 4 May 2023 04:03:01 +0000 (23:03 -0500)
commitf5c779b7ddbda30866cf2a27c63e34158f858c73
treed306574cebf6e016eb339ec2bf44515f7eaac7cb
parent3ac00a2ab69b34189942afa9e862d5170cdcb018
ksmbd: fix racy issue from session setup and logoff

This racy issue is triggered by sending concurrent session setup and
logoff requests. This patch does not set connection status as
KSMBD_SESS_GOOD if state is KSMBD_SESS_NEED_RECONNECT in session setup.
And relookup session to validate if session is deleted in logoff.

Cc: stable@vger.kernel.org
Reported-by: zdi-disclosures@trendmicro.com # ZDI-CAN-20481, ZDI-CAN-20590, ZDI-CAN-20596
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/ksmbd/connection.c
fs/ksmbd/connection.h
fs/ksmbd/mgmt/user_session.c
fs/ksmbd/server.c
fs/ksmbd/smb2pdu.c
fs/ksmbd/transport_tcp.c