iio: accel: mma9551_core: Prevent uninitialized variable in mma9551_read_config_word()
authorHarshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Thu, 26 Jan 2023 15:36:09 +0000 (07:36 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 11 Mar 2023 12:55:35 +0000 (13:55 +0100)
commitf5a2a15da3bcf5561f2141c357616885c023331c
tree4ee5dd2c6930bbcf29f175f3bfaeb0c56b551a0a
parentbe0c84d908077071702cedc3ab691398e5969a5b
iio: accel: mma9551_core: Prevent uninitialized variable in mma9551_read_config_word()

[ Upstream commit 64a68158738ec8f520347144352f7a09bdb9e169 ]

Smatch Warns:
drivers/iio/accel/mma9551_core.c:299
mma9551_read_config_word() error: uninitialized symbol 'v'.

When (offset >= 1 << 12) is true mma9551_transfer() will return -EINVAL
without 'v' being initialized, so check for the error and return.

Note: No actual bug as caller checks the return value and does not
use the parameter in the problem case.

Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Link: https://lore.kernel.org/r/20230126153610.3586243-1-harshit.m.mogalapalli@oracle.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/iio/accel/mma9551_core.c