media: ddbridge: only register frontends in fe2 if fe is not NULL
authorDaniel Scheller <d.scheller@gmx.net>
Sat, 12 Aug 2017 11:55:56 +0000 (07:55 -0400)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Sun, 20 Aug 2017 11:06:51 +0000 (07:06 -0400)
commitf597f2a8fce27b067ed5ad58314bdfbb219d2ffe
tree46bc3133c642f7ffbf68afa091e8f7aed54693c1
parente89e02a8654f3510114c72394753ab4977b754b3
media: ddbridge: only register frontends in fe2 if fe is not NULL

Smatch reported:

  drivers/media/pci/ddbridge/ddbridge-core.c:1602 dvb_input_attach() error: we previously assumed 'dvb->fe' could be null (see line 1595)

dvb->fe2 will ever only be populated when dvb->fe is set. So only handle
registration of dvb->fe2 when dvb->fe got set beforehand by moving the
registration into the "if (dvb->fe)" conditional.

Cc: Ralph Metzler <rjkm@metzlerbros.de>
Signed-off-by: Daniel Scheller <d.scheller@gmx.net>
Tested-by: Richard Scobie <r.scobie@clear.net.nz>
Tested-by: Jasmin Jessich <jasmin@anw.at>
Tested-by: Dietmar Spingler <d_spingler@freenet.de>
Tested-by: Manfred Knick <Manfred.Knick@t-online.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/pci/ddbridge/ddbridge-core.c