bpf: devmap: fix wrong interface selection in notifier_call
authorTaehee Yoo <ap420073@gmail.com>
Wed, 24 Oct 2018 11:15:17 +0000 (20:15 +0900)
committerDaniel Borkmann <daniel@iogearbox.net>
Thu, 25 Oct 2018 22:32:21 +0000 (00:32 +0200)
commitf592f804831f1cf9d1f9966f58c80f150e6829b5
tree1b4368acf0867c3ace26466ee8b44e20755acf34
parent42d0f71c9b5fd48861d61cfc05c9e001f847c9d5
bpf: devmap: fix wrong interface selection in notifier_call

The dev_map_notification() removes interface in devmap if
unregistering interface's ifindex is same.
But only checking ifindex is not enough because other netns can have
same ifindex. so that wrong interface selection could occurred.
Hence netdev pointer comparison code is added.

v2: compare netdev pointer instead of using net_eq() (Daniel Borkmann)
v1: Initial patch

Fixes: 2ddf71e23cc2 ("net: add notifier hooks for devmap bpf map")
Signed-off-by: Taehee Yoo <ap420073@gmail.com>
Acked-by: Song Liu <songliubraving@fb.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
kernel/bpf/devmap.c