usb: gadget: f_fs: stricter integer overflow checks
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 1 Sep 2022 14:59:42 +0000 (17:59 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 7 Sep 2022 14:23:22 +0000 (16:23 +0200)
commitf57004b9d96755cd6a243b51c267be4016b4563c
tree494fdc556d866c20541fda86e56315013fa6f3ab
parent6690986da1e21f3bebe1aaa54a70c636f40343b5
usb: gadget: f_fs: stricter integer overflow checks

This from static analysis.  The vla_item() takes a size and adds it to
the total.  It has a built in integer overflow check so if it encounters
an integer overflow anywhere then it records the total as SIZE_MAX.

However there is an issue here because the "lang_count*(needed_count+1)"
multiplication can overflow.  Technically the "lang_count + 1" addition
could overflow too, but that would be detected and is harmless.  Fix
both using the new size_add() and size_mul() functions.

Fixes: e6f3862fa1ec ("usb: gadget: FunctionFS: Remove VLAIS usage from gadget code")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/YxDI3lMYomE7WCjn@kili
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/gadget/function/f_fs.c