[mlir][Linalg] Drop function attribute from generic ops.
authorNicolas Vasilache <ntv@google.com>
Thu, 16 Apr 2020 13:46:00 +0000 (09:46 -0400)
committerNicolas Vasilache <ntv@google.com>
Thu, 16 Apr 2020 13:47:08 +0000 (09:47 -0400)
commitf54312277cdbc9e52657ec904ca4c1c333208c43
tree1839a18183f839a95bc574455d654088bb20ba22
parent2ec5520a54ef9b359c6154adf857ba690bc117f1
[mlir][Linalg] Drop function attribute from generic ops.

The function attribute in generic ops is not paying for itself.
A region is the more standardized way of specifying a custom computation.
If needed this region can call a function directly.
This is deemed more natural than managing a dedicated function attribute.

This also simplifies named ops generation by trimming unnecessary complexity.

Differential Revision: https://reviews.llvm.org/D78266
mlir/include/mlir/Dialect/Linalg/IR/LinalgStructuredOps.td
mlir/include/mlir/Dialect/Utils/StructuredOpsUtils.h
mlir/lib/Dialect/Linalg/EDSC/Builders.cpp
mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp
mlir/lib/Dialect/Linalg/Transforms/Fusion.cpp
mlir/lib/Dialect/Linalg/Transforms/LinalgToLoops.cpp
mlir/test/Dialect/Linalg/invalid.mlir
mlir/test/Dialect/Linalg/loops.mlir
mlir/test/Dialect/Linalg/roundtrip.mlir
mlir/test/Dialect/Linalg/transform-patterns.mlir
mlir/test/lib/DeclarativeTransforms/TestLinalgTransformPatterns.td