drm/atomic: Don't overrun the connector array when hotplugging
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Wed, 19 Nov 2014 17:38:08 +0000 (18:38 +0100)
committerDave Airlie <airlied@redhat.com>
Thu, 20 Nov 2014 01:35:20 +0000 (11:35 +1000)
commitf52b69f1ecfdd7ef6867a257620258c09e569552
tree743137d6d11bd5a9ed8bba2484de30c5f630944c
parent6f75cea66c8dd043ced282016b21a639af176642
drm/atomic: Don't overrun the connector array when hotplugging

Yet another fallout from not considering DP MST hotplug. With the
previous patches we have stable indices, but it might still happen
that a connector gets added between when we allocate the array and
when we actually add a connector. Especially when we back off due to
ww mutex contention or similar issues.

So store the sizes of the arrays in struct drm_atomic_state and double
check them. We don't really care about races except that we want to
use a consistent value, so ACCESS_ONCE is all we need. And if we
indeed notice that we'd overrun the array then just give up and
restart the entire ioctl.

Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Reviewed-by: Rob Clark <robdclark@gmail.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
drivers/gpu/drm/drm_atomic.c
drivers/gpu/drm/drm_atomic_helper.c
include/drm/drm_crtc.h