xfs: zero initialize highstale and lowstale in xfs_dir2_leaf_addname
authorDarrick J. Wong <darrick.wong@oracle.com>
Sun, 10 Mar 2019 18:41:31 +0000 (11:41 -0700)
committerDarrick J. Wong <darrick.wong@oracle.com>
Sun, 10 Mar 2019 18:41:31 +0000 (11:41 -0700)
commitf51fac68926235ef5bc482eb759d2c60b86fa358
treeced5f2bda337888b58147da16597f9f8fae2be03
parent79622c7ce6879c25ce121ee0db91c0ac4c7b137c
xfs: zero initialize highstale and lowstale in xfs_dir2_leaf_addname

Smatch complains about the following:

fs/xfs/libxfs/xfs_dir2_leaf.c:848 xfs_dir2_leaf_addname() error:
uninitialized symbol 'lowstale'.

fs/xfs/libxfs/xfs_dir2_leaf.c:849 xfs_dir2_leaf_addname() error:
uninitialized symbol 'highstale'.

I don't think there's any incorrect behavior associated with the
uninitialized variable, but as the author of the previous zero-init
patch points out, it's best not to be passing around pointers to
uninitialized stack areas.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Allison Henderson <allison.henderson@oracle.com>
Reviewed-by: Bill O'Donnell <billodo@redhat.com>
fs/xfs/libxfs/xfs_dir2_leaf.c