8250-men-mcb: fix error checking when get_num_ports returns -ENODEV
authorColin Ian King <colin.king@canonical.com>
Sun, 13 Oct 2019 22:00:16 +0000 (23:00 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 15 Oct 2019 19:38:41 +0000 (21:38 +0200)
commitf50b6805dbb993152025ec04dea094c40cc93a0c
treed4d4551500085fa5864edb96d0d9bec7c4ffe660
parent4f5cafb5cb8471e54afdc9054d973535614f7675
8250-men-mcb: fix error checking when get_num_ports returns -ENODEV

The current checking for failure on the number of ports fails when
-ENODEV is returned from the call to get_num_ports. Fix this by making
num_ports and loop counter i signed rather than unsigned ints. Also
add check for num_ports being less than zero to check for -ve error
returns.

Addresses-Coverity: ("Unsigned compared against 0")
Fixes: e2fea54e4592 ("8250-men-mcb: add support for 16z025 and 16z057")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Michael Moese <mmoese@suse.de>
Link: https://lore.kernel.org/r/20191013220016.9369-1-colin.king@canonical.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/8250/8250_men_mcb.c