rtc: davinci: Initialize drvdata before registering device
authorWolfram Sang <w.sang@pengutronix.de>
Thu, 5 May 2011 09:46:14 +0000 (11:46 +0200)
committerJohn Stultz <john.stultz@linaro.org>
Sat, 7 May 2011 00:41:06 +0000 (17:41 -0700)
commitf4e708ae8e5f3eb98f4c53036c0a470717bbc709
tree656687d744a5b89e85a44d4d9a71f29d71163015
parent5f54c8a00af20e5cf38c3e5ef2f59b6848a17cd9
rtc: davinci: Initialize drvdata before registering device

Commit f44f7f96a20 ("RTC: Initialize kernel state from RTC") uncovered
an issue in a number of RTC drivers, where the drivers call
rtc_device_register before initializing the device or platform drvdata.

This frequently results in null pointer dereferences when the
rtc_device_register immediately makes use of the rtc device, calling
rtc_read_alarm.

The solution is to ensure the drvdata is initialized prior to registering
the rtc device.

CC: Alessandro Zummo <a.zummo@towertech.it>
CC: Thomas Gleixner <tglx@linutronix.de>
CC: rtc-linux@googlegroups.com
Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
[fixed up commit log -jstultz]
Signed-off-by: John Stultz <john.stultz@linaro.org>
drivers/rtc/rtc-davinci.c