vfio-ccw: Don't call cp_free if we are processing a channel program
authorFarhan Ali <alifm@linux.ibm.com>
Thu, 11 Jul 2019 14:28:54 +0000 (10:28 -0400)
committerCornelia Huck <cohuck@redhat.com>
Mon, 15 Jul 2019 12:17:27 +0000 (14:17 +0200)
commitf4c9939433bd396d0b08e803b2b880a9d02682b9
tree76617329b6742f9c28042482fe40fb365cdf1197
parentc1ab69268d124ebdbb3864580808188ccd3ea355
vfio-ccw: Don't call cp_free if we are processing a channel program

There is a small window where it's possible that we could be working
on an interrupt (queued in the workqueue) and setting up a channel
program (i.e allocating memory, pinning pages, translating address).
This can lead to allocating and freeing the channel program at the
same time and can cause memory corruption.

Let's not call cp_free if we are currently processing a channel program.
The only way we know for sure that we don't have a thread setting
up a channel program is when the state is set to VFIO_CCW_STATE_CP_PENDING.

Fixes: d5afd5d135c8 ("vfio-ccw: add handling for async channel instructions")
Signed-off-by: Farhan Ali <alifm@linux.ibm.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Message-Id: <62e87bf67b38dc8d5760586e7c96d400db854ebe.1562854091.git.alifm@linux.ibm.com>
Reviewed-by: Eric Farman <farman@linux.ibm.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
drivers/s390/cio/vfio_ccw_drv.c