workqueue: Fix possible memory leaks in wq_numa_init()
authorZhen Lei <thunder.leizhen@huawei.com>
Thu, 22 Jul 2021 03:03:52 +0000 (11:03 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 18 Sep 2021 11:40:23 +0000 (13:40 +0200)
commitf4c7c95e3ee5741439cd11bf67b84a7d07e7c1c1
tree1695c049e3f5b905403154613951153f2f95c936
parent6528cc687c888d312bc5599bc9cdb603b3e7eb5a
workqueue: Fix possible memory leaks in wq_numa_init()

[ Upstream commit f728c4a9e8405caae69d4bc1232c54ff57b5d20f ]

In error handling branch "if (WARN_ON(node == NUMA_NO_NODE))", the
previously allocated memories are not released. Doing this before
allocating memory eliminates memory leaks.

tj: Note that the condition only occurs when the arch code is pretty broken
and the WARN_ON might as well be BUG_ON().

Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Reviewed-by: Lai Jiangshan <jiangshanlai@gmail.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
kernel/workqueue.c