ext4: fix leak of quota reservations
authorJan Kara <jack@suse.cz>
Fri, 8 Nov 2019 11:45:11 +0000 (12:45 +0100)
committerTheodore Ts'o <tytso@mit.edu>
Fri, 15 Nov 2019 00:25:47 +0000 (19:25 -0500)
commitf4c2d372b89a1e504ebb7b7eb3e29b8306479366
tree74df82e7064ee04b40d44b7eadcd1b7308e14274
parent1e1a76ed9a1c090e1ac030ed73612e5fe2262f2d
ext4: fix leak of quota reservations

Commit 8fcc3a580651 ("ext4: rework reserved cluster accounting when
invalidating pages") moved freeing of delayed allocation reservations
from dirty page invalidation time to time when we evict corresponding
status extent from extent status tree. For inodes which don't have any
blocks allocated this may actually happen only in ext4_clear_blocks()
which is after we've dropped references to quota structures from the
inode. Thus reservation of quota leaked. Fix the problem by clearing
quota information from the inode only after evicting extent status tree
in ext4_clear_inode().

Link: https://lore.kernel.org/r/20191108115420.GI20863@quack2.suse.cz
Reported-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Fixes: 8fcc3a580651 ("ext4: rework reserved cluster accounting when invalidating pages")
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/ext4/ialloc.c
fs/ext4/super.c