bpf, cgroup: Fix problematic bounds check
authorLoris Reiff <loris.reiff@liblor.ch>
Fri, 22 Jan 2021 16:42:32 +0000 (17:42 +0100)
committerDaniel Borkmann <daniel@iogearbox.net>
Fri, 22 Jan 2021 22:11:47 +0000 (23:11 +0100)
commitf4a2da755a7e1f5d845c52aee71336cee289935a
tree5d8ffc8d9b3a7f18fc706b2aeffb6fa059b370d3
parentbb8b81e396f7afbe7c50d789e2107512274d2a35
bpf, cgroup: Fix problematic bounds check

Since ctx.optlen is signed, a larger value than max_value could be
passed, as it is later on used as unsigned, which causes a WARN_ON_ONCE
in the copy_to_user.

Fixes: 0d01da6afc54 ("bpf: implement getsockopt and setsockopt hooks")
Signed-off-by: Loris Reiff <loris.reiff@liblor.ch>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Reviewed-by: Stanislav Fomichev <sdf@google.com>
Link: https://lore.kernel.org/bpf/20210122164232.61770-2-loris.reiff@liblor.ch
kernel/bpf/cgroup.c