drm/i2c: tda998x: Replace all non-returning strlcpy with strscpy
authorAzeem Shaikh <azeemshaikh38@gmail.com>
Mon, 22 May 2023 15:53:50 +0000 (15:53 +0000)
committerKees Cook <keescook@chromium.org>
Thu, 1 Jun 2023 14:07:37 +0000 (07:07 -0700)
commitf4a0659f823e5a828ea2f45b4849ea8e2dd2984c
treeae37663b5b96d822102ee9a2fba6f76eb85772af
parent8360257608f74946a985400f1994d3eea9b74a85
drm/i2c: tda998x: Replace all non-returning strlcpy with strscpy

strlcpy() reads the entire source buffer first.
This read may exceed the destination size limit.
This is both inefficient and can lead to linear read
overflows if a source string is not NUL-terminated [1].
In an effort to remove strlcpy() completely [2], replace
strlcpy() here with strscpy().
No return values were used, so direct replacement is safe.

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89

Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20230522155350.2337029-1-azeemshaikh38@gmail.com
drivers/gpu/drm/i2c/tda998x_drv.c