Fix use of a dangling pointer for Python breakpoint objects
authorPierre-Marie de Rodat <derodat@adacore.com>
Mon, 27 Jun 2016 10:11:25 +0000 (12:11 +0200)
committerPierre-Marie de Rodat <derodat@adacore.com>
Mon, 27 Jun 2016 10:11:25 +0000 (12:11 +0200)
commitf4952523968703caa027a5922263eb97b88bedc3
tree089ad47429f388e7f85cc1777cca8fe21e91415f
parent3cd72572cbbf3bb720a41af1db26e81898c318c2
Fix use of a dangling pointer for Python breakpoint objects

When a Python script tries to create a breakpoint but fails to do so,
gdb.Breakpoint.__init__ raises an exception and the breakpoint does not
exist anymore in the Python interpreter. However, GDB still keeps a
reference to the Python object to be used for a later hook, which is
wrong.

This commit adds the necessary cleanup code so that there is no stale
reference to this Python object. It also adds a new testcase to
reproduce the bug and check the fix.

2016-06-25  Pierre-Marie de Rodat  <derodat@adacore.com>

gdb/
* python/py-breakpoint.c (bppy_init): Clear bppy_pending_object
when there is an error during the breakpoint creation.

gdb/testsuite

* gdb.python/py-breakpoint-create-fail.c,
gdb.python/py-breakpoint-create-fail.exp,
gdb.python/py-breakpoint-create-fail.py: New testcase.
gdb/ChangeLog
gdb/python/py-breakpoint.c
gdb/testsuite/ChangeLog
gdb/testsuite/gdb.python/py-breakpoint-create-fail.c [new file with mode: 0644]
gdb/testsuite/gdb.python/py-breakpoint-create-fail.exp [new file with mode: 0644]
gdb/testsuite/gdb.python/py-breakpoint-create-fail.py [new file with mode: 0644]