environ-selftests: Ignore -Wself-move warning
authorPedro Alves <palves@redhat.com>
Thu, 22 Jun 2017 08:31:20 +0000 (10:31 +0200)
committerPedro Alves <palves@redhat.com>
Thu, 22 Jun 2017 10:18:49 +0000 (11:18 +0100)
commitf4906a9a7441ef9c2758513420568994a1e7fed3
tree5804fcca8711a500899a8c9179c4375fee663aed
parentd269dfc64fb5307dbbaecbc5d55861a705b729ab
environ-selftests: Ignore -Wself-move warning

clang gives this warning:

 ..../gdb/unittests/environ-selftests.c:139:7: error: explicitly moving variable of type 'gdb_environ' to itself [-Werror,-Wself-move]
   env = std::move (env);
   ~~~ ^            ~~~

Ignoring the warning locally is the right thing to do, since it warns
about behavior we want to unit test, while an explicit self-move in
real code would likely be a mistake that we'd want to catch.

To avoid cluttering the code with preprocessor conditionals, this
commit adds the file common/diagnostics.h, in which we can put macros
used to control compiler diagnostics.

GCC enhancement request here:
  https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81159

gdb/ChangeLog:
2017-06-22  Pedro Alves  <palves@redhat.com>
    Simon Marchi  <simon.marchi@ericsson.com>

* unittests/environ-selftests.c (run_tests): Ignore -Wself-move
warning.
* common/diagnostics.h: New file.
gdb/ChangeLog
gdb/common/diagnostics.h [new file with mode: 0644]
gdb/unittests/environ-selftests.c