blk-iocost: don't ignore vrate_min on QD contention
authorTejun Heo <tj@kernel.org>
Fri, 23 Apr 2021 01:54:28 +0000 (21:54 -0400)
committerJens Axboe <axboe@kernel.dk>
Mon, 26 Apr 2021 12:44:18 +0000 (06:44 -0600)
commitf46ec84b5acbf8d7067d71a6bbdde213d4b86036
tree752b0dc8602de6580ee5ab5699662c6814ea87d1
parent1e91e28e374d0b0b912154c192716374609360d9
blk-iocost: don't ignore vrate_min on QD contention

ioc_adjust_base_vrate() ignored vrate_min when rq_wait_pct indicates that
there is QD contention. The reasoning was that QD depletion always reliably
indicates device saturation and thus it's safe to override user specified
vrate_min. However, this sometimes leads to unnecessary throttling,
especially on really fast devices, because vrate adjustments have delays and
inertia. It also confuses users because the behavior violates the explicitly
specified configuration.

This patch drops the special case handling so that vrate_min is always
applied.

Signed-off-by: Tejun Heo <tj@kernel.org>
Link: https://lore.kernel.org/r/YIIo1HuyNmhDeiNx@slm.duckdns.org
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-iocost.c