stmmac: fix pointer check after utilization in stmmac_interrupt
authorMaxim Petrov <mmrmaximuzz@gmail.com>
Mon, 4 May 2020 06:26:43 +0000 (09:26 +0300)
committerDavid S. Miller <davem@davemloft.net>
Mon, 4 May 2020 17:33:53 +0000 (10:33 -0700)
commitf42234ffd531ca6b13d9da02faa60b72eccf8334
tree900040f116fccd53a8b938e11f845030d333ac87
parent980d69276f3048af43a045be2925dacfb898a7be
stmmac: fix pointer check after utilization in stmmac_interrupt

The paranoidal pointer check in IRQ handler looks very strange - it
really protects us only against bogus drivers which request IRQ line
with null pointer dev_id. However, the code fragment is incorrect
because the dev pointer is used before the actual check which leads
to undefined behavior. Remove the check to avoid confusing people
with incorrect code.

Signed-off-by: Maxim Petrov <mmrmaximuzz@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c