powerpc/papr_scm: Reduce error severity if nvdimm stats inaccessible
authorVaibhav Jain <vaibhav@linux.ibm.com>
Sat, 8 May 2021 04:36:42 +0000 (10:06 +0530)
committerMichael Ellerman <mpe@ellerman.id.au>
Mon, 17 May 2021 05:27:15 +0000 (15:27 +1000)
commitf3f6d18417eb44ef393b23570d384d2778ef22dc
tree19f1d3f1fe23fb804cdab628989c07fa73187a98
parent13c7dad95176d6abaf9608e4d34b2f512689775e
powerpc/papr_scm: Reduce error severity if nvdimm stats inaccessible

Currently drc_pmem_qeury_stats() generates a dev_err in case
"Enable Performance Information Collection" feature is disabled from
HMC or performance stats are not available for an nvdimm. The error is
of the form below:

papr_scm ibm,persistent-memory:ibm,pmemory@44104001: Failed to query
 performance stats, Err:-10

This error message confuses users as it implies a possible problem
with the nvdimm even though its due to a disabled/unavailable
feature. We fix this by explicitly handling the H_AUTHORITY and
H_UNSUPPORTED errors from the H_SCM_PERFORMANCE_STATS hcall.

In case of H_AUTHORITY error an info message is logged instead of an
error, saying that "Permission denied while accessing performance
stats" and an EPERM error is returned back.

In case of H_UNSUPPORTED error we return a EOPNOTSUPP error back from
drc_pmem_query_stats() indicating that performance stats-query
operation is not supported on this nvdimm.

Fixes: 2d02bf835e57 ("powerpc/papr_scm: Fetch nvdimm performance stats from PHYP")
Signed-off-by: Vaibhav Jain <vaibhav@linux.ibm.com>
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20210508043642.114076-1-vaibhav@linux.ibm.com
arch/powerpc/platforms/pseries/papr_scm.c