perf: Add a few assertions
authorPeter Zijlstra <peterz@infradead.org>
Fri, 2 Sep 2022 16:48:55 +0000 (18:48 +0200)
committerPeter Zijlstra <peterz@infradead.org>
Wed, 7 Sep 2022 19:54:01 +0000 (21:54 +0200)
commitf3c0eba287049237b23d1300376768293eb89e69
treeceb5cab8cd9b1733b4504a639a63454c4d4c746c
parent88081cfb699ce2568e5309c145eb9f9e9497b53f
perf: Add a few assertions

While auditing 6b959ba22d34 ("perf/core: Fix reentry problem in
perf_output_read_group()") a few spots were found that wanted
assertions.

Notable for_each_sibling_event() relies on exclusion from
modification. This would normally be holding either ctx->lock or
ctx->mutex, however due to how things are constructed disabling IRQs
is a valid and sufficient substitute for ctx->lock.

Another possible site to add assertions would be the various
pmu::{add,del,read,..}() methods, but that's not trivially expressable
in C -- the best option is wrappers, but those are easy enough to
forget.

Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
include/linux/perf_event.h
kernel/events/core.c