Change file close behavior for tee_file
authorAlan Hayward <alan.hayward@arm.com>
Fri, 17 May 2019 13:07:04 +0000 (14:07 +0100)
committerAlan Hayward <alan.hayward@arm.com>
Fri, 17 May 2019 13:07:04 +0000 (14:07 +0100)
commitf3a09c800fcd1d597fa2b9578cb59adfc15b698d
tree0cfd6d8b1c65fb029a59d706d47aee2f92c990c7
parentaf4fa23fba220c1b26bb3c8a7996b406dcc181cc
Change file close behavior for tee_file

Instead of using two bools to decide if the files should close when tee_file
is closed, make file one stay open and file two close.  This simplifies the
use cases for it.

Inline the make_logging_output into the calling functions (the logic here
looks ugly in order to simplify a later change).

Expand ui-redirect.exp to cover the changes, similar to mi-logging.exp.

gdb/ChangeLog:

* cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
directly.
* cli/cli-interp.h (make_logging_output): Remove declaration.
* cli/cli-logging.c (make_logging_output): Remove function.
* mi/mi-interp.c (mi_interp::set_logging): Create tee_file
directly.
* ui-file.c (tee_file::tee_file): Remove bools.
(tee_file::~tee_file): Remove deletes.
* ui-file.h (tee_file): Remove bools.

gdb/testsuite/ChangeLog:

* gdb.base/ui-redirect.exp: Test redirection.
gdb/ChangeLog
gdb/cli/cli-interp.c
gdb/cli/cli-interp.h
gdb/cli/cli-logging.c
gdb/mi/mi-interp.c
gdb/testsuite/ChangeLog
gdb/testsuite/gdb.base/ui-redirect.exp
gdb/ui-file.c
gdb/ui-file.h