perf tools: Move dereference after NULL test
authorJulia Lawall <julia@diku.dk>
Sat, 17 Oct 2009 06:43:17 +0000 (08:43 +0200)
committerIngo Molnar <mingo@elte.hu>
Sat, 17 Oct 2009 07:29:10 +0000 (09:29 +0200)
commitf39cdf25bf77219676ec5360980ac40b1a7e144a
tree2143a3653933efc5ffacea647ce8be72952b3a44
parent434a83c3fbb951908a3a52040f7f0e0b8ba00dd0
perf tools: Move dereference after NULL test

In each case, if the NULL test on thread is needed, then the
dereference should be after the NULL test.

A simplified version of the semantic match that detects this
problem is as follows (http://coccinelle.lip6.fr/):

// <smpl>
@match exists@
expression x, E;
identifier fld;
@@

* x->fld
  ... when != \(x = E\|&x\)
* x == NULL
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
LKML-Reference: <Pine.LNX.4.64.0910170842500.9213@ask.diku.dk>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
tools/perf/builtin-annotate.c
tools/perf/builtin-report.c
tools/perf/builtin-sched.c
tools/perf/builtin-trace.c