media: go7007: Remove redundant if statement
authorColin Ian King <colin.i.king@gmail.com>
Thu, 27 Jul 2023 17:40:07 +0000 (19:40 +0200)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Thu, 10 Aug 2023 05:58:32 +0000 (07:58 +0200)
commitf33cb49081da0ec5af0888f8ecbd566bd326eed1
tree67b3f4881bdc97a8395b22dbc9f01f3aee67228f
parent2545a2c02ba1da9cfb9ec218623c71b00eb4a555
media: go7007: Remove redundant if statement

The if statement that compares msgs[i].len != 3 is always false because
it is in a code block where msg[i].len is equal to 3. The check is
redundant and can be removed.

As detected by cppcheck static analysis:
drivers/media/usb/go7007/go7007-i2c.c:168:20: warning: Opposite inner
'if' condition leads to a dead code block. [oppositeInnerCondition]

Link: https://lore.kernel.org/linux-media/20230727174007.635572-1-colin.i.king@gmail.com
Fixes: 866b8695d67e ("Staging: add the go7007 video driver")
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/usb/go7007/go7007-i2c.c