[llvm-cxxfilt] Replace isalnum with isAlnum from StringExtras
authorTomasz Miąsko <tomasz.miasko@gmail.com>
Sat, 2 Oct 2021 05:58:54 +0000 (07:58 +0200)
committerTomasz Miąsko <tomasz.miasko@gmail.com>
Sat, 2 Oct 2021 06:54:04 +0000 (08:54 +0200)
commitf33274c7bf44af652f1b52f1566552620f72ce1f
treeccbe934c6480dcd27068575cb58763d9925b9957
parentf41a9cf859a1032d604dd4d02887432441e7966f
[llvm-cxxfilt] Replace isalnum with isAlnum from StringExtras

D104366 introduced a new llvm-cxxfilt test with non-ASCII characters,
which caused a failure on llvm-clang-x86_64-expensive-checks-win
builder, with a stack trace suggesting issue in a call to isalnum.

The argument to isalnum should be either EOF or a value that is
representable in the type unsigned char. The llvm-cxxfilt does not
perform a cast from char to unsigned char before the call, so the
value might be out of valid range.

Replace the call to isalnum with isAlnum from StringExtras, which takes
a char as the argument. This also makes the check independent of the
current locale.

Differential Revision: https://reviews.llvm.org/D110986
llvm/test/tools/llvm-cxxfilt/delimiters.test
llvm/tools/llvm-cxxfilt/llvm-cxxfilt.cpp