Code cleanup and formatting for System.Memory files. (#17451)
authorAhson Khan <ahkha@microsoft.com>
Tue, 22 May 2018 01:03:55 +0000 (18:03 -0700)
committerGitHub <noreply@github.com>
Tue, 22 May 2018 01:03:55 +0000 (18:03 -0700)
commitf31097f14560b193e76a7b2e1e61af9870b5356b
tree781ac579824a68f50f00b68d293cefc9e0a2d9be
parent49f6249abc44269b437064e850ad22eb9f74a446
Code cleanup and formatting for System.Memory files. (#17451)

* Fix IDE0034 C# expression can be simplified (use of default)

* Remove unnecessary using statements

* IDE0012 C# Name can be simplified. String -> string

* IDE0041  C# Null check can be simplified

* Fix code formatting (limited to Span/System.Memory files).

* Address PR feedback - IDE0012 Name can be simplified (String -> string)

* Add back the necessary using statements and fix typo

* Fix comment typo and add necessary using statements
156 files changed:
src/System.Private.CoreLib/Common/System/SR.cs
src/System.Private.CoreLib/shared/System/ArgumentException.cs
src/System.Private.CoreLib/shared/System/ArraySegment.cs
src/System.Private.CoreLib/shared/System/Buffers/MemoryHandle.cs
src/System.Private.CoreLib/shared/System/Buffers/MemoryManager.cs
src/System.Private.CoreLib/shared/System/Collections/Concurrent/ConcurrentQueue.cs
src/System.Private.CoreLib/shared/System/Convert.cs
src/System.Private.CoreLib/shared/System/DateTimeOffset.cs
src/System.Private.CoreLib/shared/System/Diagnostics/Tracing/EventProvider.cs
src/System.Private.CoreLib/shared/System/Diagnostics/Tracing/EventSource.cs
src/System.Private.CoreLib/shared/System/Diagnostics/Tracing/StubEnvironment.cs
src/System.Private.CoreLib/shared/System/Diagnostics/Tracing/TraceLogging/EventPayload.cs
src/System.Private.CoreLib/shared/System/Diagnostics/Tracing/TraceLogging/PropertyValue.cs
src/System.Private.CoreLib/shared/System/Diagnostics/Tracing/TraceLogging/TraceLoggingEventSource.cs
src/System.Private.CoreLib/shared/System/Globalization/Calendar.cs
src/System.Private.CoreLib/shared/System/Globalization/CalendarData.cs
src/System.Private.CoreLib/shared/System/Globalization/ChineseLunisolarCalendar.cs
src/System.Private.CoreLib/shared/System/Globalization/CompareInfo.cs
src/System.Private.CoreLib/shared/System/Globalization/CultureNotFoundException.cs
src/System.Private.CoreLib/shared/System/Globalization/DateTimeFormat.cs
src/System.Private.CoreLib/shared/System/Globalization/DateTimeFormatInfoScanner.cs
src/System.Private.CoreLib/shared/System/Globalization/DateTimeParse.cs
src/System.Private.CoreLib/shared/System/Globalization/EastAsianLunisolarCalendar.cs
src/System.Private.CoreLib/shared/System/Globalization/GregorianCalendar.cs
src/System.Private.CoreLib/shared/System/Globalization/GregorianCalendarHelper.cs
src/System.Private.CoreLib/shared/System/Globalization/HebrewCalendar.cs
src/System.Private.CoreLib/shared/System/Globalization/HijriCalendar.Win32.cs
src/System.Private.CoreLib/shared/System/Globalization/HijriCalendar.cs
src/System.Private.CoreLib/shared/System/Globalization/JapaneseCalendar.cs
src/System.Private.CoreLib/shared/System/Globalization/JapaneseLunisolarCalendar.cs
src/System.Private.CoreLib/shared/System/Globalization/JulianCalendar.cs
src/System.Private.CoreLib/shared/System/Globalization/KoreanCalendar.cs
src/System.Private.CoreLib/shared/System/Globalization/NumberFormatInfo.cs
src/System.Private.CoreLib/shared/System/Globalization/PersianCalendar.cs
src/System.Private.CoreLib/shared/System/Globalization/RegionInfo.cs
src/System.Private.CoreLib/shared/System/Globalization/StringInfo.cs
src/System.Private.CoreLib/shared/System/Globalization/TaiwanCalendar.cs
src/System.Private.CoreLib/shared/System/Globalization/TaiwanLunisolarCalendar.cs
src/System.Private.CoreLib/shared/System/Globalization/ThaiBuddhistCalendar.cs
src/System.Private.CoreLib/shared/System/Globalization/TimeSpanParse.cs
src/System.Private.CoreLib/shared/System/Globalization/UmAlQuraCalendar.cs
src/System.Private.CoreLib/shared/System/Guid.cs
src/System.Private.CoreLib/shared/System/IO/FileStream.Windows.cs
src/System.Private.CoreLib/shared/System/IO/FileStream.cs
src/System.Private.CoreLib/shared/System/IO/MemoryStream.cs
src/System.Private.CoreLib/shared/System/IO/TextReader.cs
src/System.Private.CoreLib/shared/System/IO/TextWriter.cs
src/System.Private.CoreLib/shared/System/IO/UnmanagedMemoryStream.cs
src/System.Private.CoreLib/shared/System/IO/UnmanagedMemoryStreamWrapper.cs
src/System.Private.CoreLib/shared/System/Lazy.cs
src/System.Private.CoreLib/shared/System/MemoryDebugView.cs
src/System.Private.CoreLib/shared/System/MemoryExtensions.cs
src/System.Private.CoreLib/shared/System/ObjectDisposedException.cs
src/System.Private.CoreLib/shared/System/ReadOnlySpan.Fast.cs
src/System.Private.CoreLib/shared/System/ReadOnlySpan.cs
src/System.Private.CoreLib/shared/System/Runtime/CompilerServices/YieldAwaitable.cs
src/System.Private.CoreLib/shared/System/Runtime/InteropServices/ExternalException.cs
src/System.Private.CoreLib/shared/System/Runtime/InteropServices/MemoryMarshal.Fast.cs
src/System.Private.CoreLib/shared/System/Runtime/InteropServices/MemoryMarshal.cs
src/System.Private.CoreLib/shared/System/Runtime/InteropServices/SafeBuffer.cs
src/System.Private.CoreLib/shared/System/Span.Fast.cs
src/System.Private.CoreLib/shared/System/Span.cs
src/System.Private.CoreLib/shared/System/SpanDebugView.cs
src/System.Private.CoreLib/shared/System/SpanHelpers.BinarySearch.cs
src/System.Private.CoreLib/shared/System/SpanHelpers.Byte.cs
src/System.Private.CoreLib/shared/System/SpanHelpers.T.cs
src/System.Private.CoreLib/shared/System/SpanHelpers.cs
src/System.Private.CoreLib/shared/System/String.Searching.cs
src/System.Private.CoreLib/shared/System/Text/ASCIIEncoding.cs
src/System.Private.CoreLib/shared/System/Text/Encoding.cs
src/System.Private.CoreLib/shared/System/Text/EncodingNLS.cs
src/System.Private.CoreLib/shared/System/Text/StringBuilder.cs
src/System.Private.CoreLib/shared/System/Text/UTF32Encoding.cs
src/System.Private.CoreLib/shared/System/Text/UTF7Encoding.cs
src/System.Private.CoreLib/shared/System/Text/UTF8Encoding.cs
src/System.Private.CoreLib/shared/System/Text/UnicodeEncoding.cs
src/System.Private.CoreLib/shared/System/Threading/AsyncLocal.cs
src/System.Private.CoreLib/shared/System/Threading/Tasks/ConcurrentExclusiveSchedulerPair.cs
src/System.Private.CoreLib/shared/System/Threading/Tasks/TaskCompletionSource.cs
src/System.Private.CoreLib/shared/System/TimeSpan.cs
src/System.Private.CoreLib/shared/System/TimeZoneInfo.AdjustmentRule.cs
src/System.Private.CoreLib/shared/System/TimeZoneInfo.Win32.cs
src/System.Private.CoreLib/shared/System/TypeInitializationException.cs
src/System.Private.CoreLib/shared/System/ValueTuple.cs
src/System.Private.CoreLib/shared/System/Version.cs
src/System.Private.CoreLib/src/Microsoft/Win32/RegistryKey.cs
src/System.Private.CoreLib/src/System/AppContext/AppContextDefaultValues.cs
src/System.Private.CoreLib/src/System/Array.cs
src/System.Private.CoreLib/src/System/Collections/Concurrent/ConcurrentDictionary.cs
src/System.Private.CoreLib/src/System/Collections/Concurrent/ConcurrentStack.cs
src/System.Private.CoreLib/src/System/Diagnostics/Contracts/Contracts.cs
src/System.Private.CoreLib/src/System/Diagnostics/Contracts/ContractsBCL.cs
src/System.Private.CoreLib/src/System/Diagnostics/Debug.Windows.cs
src/System.Private.CoreLib/src/System/Diagnostics/Stacktrace.cs
src/System.Private.CoreLib/src/System/Enum.cs
src/System.Private.CoreLib/src/System/GC.cs
src/System.Private.CoreLib/src/System/Globalization/CultureInfo.cs
src/System.Private.CoreLib/src/System/IO/BinaryReader.cs
src/System.Private.CoreLib/src/System/IO/Stream.cs
src/System.Private.CoreLib/src/System/Internal.cs
src/System.Private.CoreLib/src/System/Object.cs
src/System.Private.CoreLib/src/System/Reflection/CustomAttribute.cs
src/System.Private.CoreLib/src/System/Reflection/Emit/DynamicILGenerator.cs
src/System.Private.CoreLib/src/System/Reflection/Emit/EnumBuilder.cs
src/System.Private.CoreLib/src/System/Reflection/Emit/GenericTypeParameterBuilder.cs
src/System.Private.CoreLib/src/System/Reflection/Emit/ModuleBuilder.cs
src/System.Private.CoreLib/src/System/Reflection/Emit/ModuleBuilderData.cs
src/System.Private.CoreLib/src/System/Reflection/Emit/SymbolType.cs
src/System.Private.CoreLib/src/System/Reflection/Emit/TypeBuilder.cs
src/System.Private.CoreLib/src/System/Reflection/Emit/TypeBuilderInstantiation.cs
src/System.Private.CoreLib/src/System/Reflection/ExceptionHandlingClause.cs
src/System.Private.CoreLib/src/System/Reflection/FieldInfo.CoreCLR.cs
src/System.Private.CoreLib/src/System/Reflection/MdConstant.cs
src/System.Private.CoreLib/src/System/Reflection/MdImport.cs
src/System.Private.CoreLib/src/System/Reflection/MethodBase.CoreCLR.cs
src/System.Private.CoreLib/src/System/Reflection/RtFieldInfo.cs
src/System.Private.CoreLib/src/System/Reflection/RuntimeAssembly.cs
src/System.Private.CoreLib/src/System/Reflection/RuntimeConstructorInfo.cs
src/System.Private.CoreLib/src/System/Reflection/RuntimeModule.cs
src/System.Private.CoreLib/src/System/Resources/ManifestBasedResourceGroveler.cs
src/System.Private.CoreLib/src/System/Resources/ResourceManager.cs
src/System.Private.CoreLib/src/System/Resources/ResourceReader.cs
src/System.Private.CoreLib/src/System/Resources/__FastResourceComparer.cs
src/System.Private.CoreLib/src/System/RtType.cs
src/System.Private.CoreLib/src/System/Runtime/CompilerServices/AsyncMethodBuilder.cs
src/System.Private.CoreLib/src/System/Runtime/CompilerServices/ConditionalWeakTable.cs
src/System.Private.CoreLib/src/System/Runtime/CompilerServices/TaskAwaiter.cs
src/System.Private.CoreLib/src/System/Runtime/InteropServices/Marshal.cs
src/System.Private.CoreLib/src/System/Runtime/InteropServices/WindowsRuntime/ConstantSplittableMap.cs
src/System.Private.CoreLib/src/System/Runtime/InteropServices/WindowsRuntime/CustomPropertyImpl.cs
src/System.Private.CoreLib/src/System/Runtime/InteropServices/WindowsRuntime/EnumeratorToIteratorAdapter.cs
src/System.Private.CoreLib/src/System/Runtime/InteropServices/WindowsRuntime/IMapViewToIReadOnlyDictionaryAdapter.cs
src/System.Private.CoreLib/src/System/Runtime/InteropServices/WindowsRuntime/IReadOnlyListToIVectorViewAdapter.cs
src/System.Private.CoreLib/src/System/Runtime/InteropServices/WindowsRuntime/ListToVectorAdapter.cs
src/System.Private.CoreLib/src/System/Runtime/InteropServices/WindowsRuntime/MapToDictionaryAdapter.cs
src/System.Private.CoreLib/src/System/Runtime/InteropServices/WindowsRuntime/WindowsRuntimeMarshal.cs
src/System.Private.CoreLib/src/System/Runtime/InteropServices/WindowsRuntime/WindowsRuntimeMetadata.cs
src/System.Private.CoreLib/src/System/Runtime/Loader/AssemblyLoadContext.cs
src/System.Private.CoreLib/src/System/Runtime/MemoryFailPoint.cs
src/System.Private.CoreLib/src/System/StubHelpers.cs
src/System.Private.CoreLib/src/System/Text/EncodingTable.cs
src/System.Private.CoreLib/src/System/Threading/CancellationToken.cs
src/System.Private.CoreLib/src/System/Threading/CancellationTokenRegistration.cs
src/System.Private.CoreLib/src/System/Threading/CancellationTokenSource.cs
src/System.Private.CoreLib/src/System/Threading/ClrThreadPoolPreAllocatedOverlapped.cs
src/System.Private.CoreLib/src/System/Threading/ManualResetEventSlim.cs
src/System.Private.CoreLib/src/System/Threading/SemaphoreSlim.cs
src/System.Private.CoreLib/src/System/Threading/Tasks/AsyncCausalityTracer.cs
src/System.Private.CoreLib/src/System/Threading/Tasks/FutureFactory.cs
src/System.Private.CoreLib/src/System/Threading/Tasks/ProducerConsumerQueues.cs
src/System.Private.CoreLib/src/System/Threading/Tasks/Task.cs
src/System.Private.CoreLib/src/System/Threading/Tasks/TaskContinuation.cs
src/System.Private.CoreLib/src/System/Threading/Tasks/TaskFactory.cs
src/System.Private.CoreLib/src/System/Threading/Tasks/future.cs
src/System.Private.CoreLib/src/System/Threading/ThreadLocal.cs
src/System.Private.CoreLib/src/System/TypeLoadException.cs