agp/intel: Reinforce the barrier after GTT updates
authorChris Wilson <chris@chris-wilson.co.uk>
Fri, 10 Apr 2020 08:35:35 +0000 (09:35 +0100)
committerChris Wilson <chris@chris-wilson.co.uk>
Fri, 10 Apr 2020 13:56:11 +0000 (14:56 +0100)
commitf30d3ced9fafa03e4855508929b5b6334907f45e
tree11053481d7309237862e0d039b371f01ab974405
parentc1b5ea926d55239e3e66e41030d9c45c7b876310
agp/intel: Reinforce the barrier after GTT updates

After changing the timing between GTT updates and execution on the GPU,
we started seeing sporadic failures on Ironlake. These were narrowed
down to being an insufficiently strong enough barrier/delay after
updating the GTT and scheduling execution on the GPU. By forcing the
uncached read, and adding the missing barrier for the singular
insert_page (relocation paths), the sporadic failures go away.

Fixes: 983d308cb8f6 ("agp/intel: Serialise after GTT updates")
Fixes: 3497971a71d8 ("agp/intel: Flush chipset writes after updating a single PTE")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Acked-by: Andi Shyti <andi.shyti@intel.com>
Cc: stable@vger.kernel.org # v4.0+
Link: https://patchwork.freedesktop.org/patch/msgid/20200410083535.25464-1-chris@chris-wilson.co.uk
drivers/char/agp/intel-gtt.c