509: fix printing uninitialized stack memory when OID is empty
authorEric Biggers <ebiggers3@gmail.com>
Fri, 8 Dec 2017 15:13:28 +0000 (15:13 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 25 Feb 2018 10:08:01 +0000 (11:08 +0100)
commitf2f12ea19faee9dc0b1d80a90630df47cbb6d5f5
treed6de1bbe4a6c4b1616ed4ac2854d12d8e4fa2454
parent9c65a55722acf228bdf194954fe02084c1f1eeb1
509: fix printing uninitialized stack memory when OID is empty

[ Upstream commit 8dfd2f22d3bf3ab7714f7495ad5d897b8845e8c1 ]

Callers of sprint_oid() do not check its return value before printing
the result.  In the case where the OID is zero-length, -EBADMSG was
being returned without anything being written to the buffer, resulting
in uninitialized stack memory being printed.  Fix this by writing
"(bad)" to the buffer in the cases where -EBADMSG is returned.

Fixes: 4f73175d0375 ("X.509: Add utility functions to render OIDs as strings")
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
lib/oid_registry.c