batman-adv: Deactivate TO_BE_ACTIVATED hardif on shutdown
authorSven Eckelmann <sven@narfation.org>
Sat, 19 Mar 2016 12:55:21 +0000 (13:55 +0100)
committerAntonio Quartulli <a@unstable.cc>
Sun, 24 Apr 2016 07:40:23 +0000 (15:40 +0800)
commitf2d23861b818d08bcd15cc1612ae94aa33b3931c
tree922815be7d079dbb474d3ecb259cfe520f750d7a
parente48474ed8a217b7f80f2a42bc05352406a06cb67
batman-adv: Deactivate TO_BE_ACTIVATED hardif on shutdown

The shutdown of an batman-adv interface can happen with one of its slave
interfaces still being in the BATADV_IF_TO_BE_ACTIVATED state. A possible
reason for it is that the routing algorithm BATMAN_V was selected and
batadv_schedule_bat_ogm was not yet called for this interface. This slave
interface still has to be set to BATADV_IF_INACTIVE or the batman-adv
interface will never reduce its usage counter and thus never gets shutdown.

This problem can be simulated via:

    $ modprobe dummy
    $ modprobe batman-adv routing_algo=BATMAN_V
    $ ip link add bat0 type batadv
    $ ip link set dummy0 master bat0
    $ ip link set dummy0 up
    $ ip link del bat0
    unregister_netdevice: waiting for bat0 to become free. Usage count = 3

Reported-by: Matthias Schiffer <mschiffer@universe-factory.net>
Signed-off-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
Signed-off-by: Antonio Quartulli <a@unstable.cc>
net/batman-adv/hard-interface.c