net/x25: Fix to not accept on connected socket
authorHyunwoo Kim <v4bel@theori.io>
Mon, 23 Jan 2023 19:43:23 +0000 (11:43 -0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 25 Jan 2023 09:51:04 +0000 (09:51 +0000)
commitf2b0b5210f67c56a3bcdf92ff665fb285d6e0067
tree6011f2b3ac88b3e1e2d0c6dc5a57b5fe88e33afa
parent2a48216cff7a2e3964fbed16f84d33f68b3e5e42
net/x25: Fix to not accept on connected socket

When listen() and accept() are called on an x25 socket
that connect() succeeds, accept() succeeds immediately.
This is because x25_connect() queues the skb to
sk->sk_receive_queue, and x25_accept() dequeues it.

This creates a child socket with the sk of the parent
x25 socket, which can cause confusion.

Fix x25_listen() to return -EINVAL if the socket has
already been successfully connect()ed to avoid this issue.

Signed-off-by: Hyunwoo Kim <v4bel@theori.io>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/x25/af_x25.c