qtdemux: Don't stop task when resetting
authorEdward Hervey <edward@centricular.com>
Wed, 27 Jul 2022 09:19:50 +0000 (11:19 +0200)
committerEdward Hervey <bilboed@bilboed.com>
Mon, 3 Oct 2022 12:41:18 +0000 (14:41 +0200)
commitf2a17692365b14e354d65bfe7ffc99cbd63b3d13
treeb668a53187ddf260cb97b14abc3d85210a3c7303
parent237b063843dd069ff79d2de890e10ea9c5abfccb
qtdemux: Don't stop task when resetting

This is a regression that was introduced in
cca2f555d14b5751f7f9d466b66127544dad5138 (yes, 9 years ago).

The only place where a demuxer streaming thread should be stopped is when the
sinkpad is deactivated from pull mode (i.e. PAUSED->READY).

Attempting to stop the task in this function would cause this to happen when a
FLUSH_STOP or STREAM_START event is received... which can cause deadlocks.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3109>
subprojects/gst-plugins-good/gst/isomp4/qtdemux.c