tracing: Remove comparing of NULL to va_list in trace_array_vprintk()
authorCarsten Emde <Carsten.Emde@osadl.org>
Sun, 6 Dec 2009 13:02:44 +0000 (14:02 +0100)
committerSteven Rostedt <rostedt@goodmis.org>
Wed, 9 Dec 2009 19:20:08 +0000 (14:20 -0500)
commitf2942487ffb0c0a80b2312f667ea30dd55a24bb0
tree8e6e4c8ae8230f2648142c863e8482b7656e6614
parentbe1eca39319689aed7d3aedb9c3bece9469fe10f
tracing: Remove comparing of NULL to va_list in trace_array_vprintk()

Olof Johansson stated the following:

  Comparing a va_list with NULL is bogus. It's supposed to be treated like
  an opaque type and only be manipulated with va_* accessors.

Olof noticed that this code broke the ARM builds:

    kernel/trace/trace.c: In function 'trace_array_vprintk':
    kernel/trace/trace.c:1364: error: invalid operands to binary == (have 'va_list' and 'void *')
    kernel/trace/trace.c: In function 'tracing_mark_write':
    kernel/trace/trace.c:3349: error: incompatible type for argument 3 of 'trace_vprintk'

This patch partly reverts c13d2f7c3231e873f30db92b96c8caa48f100f33 and
re-installs the original mark_printk() mechanism.

Reported-by: Olof Johansson <olof@lixom.net>
Signed-off-by: Carsten Emde <C.Emde@osadl.org>
LKML-Reference: <4B1BAB74.104@osadl.org>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
kernel/trace/trace.c